[ISSUE #1030] avoid to append unexpected separator to the last messag…

…e key
apache · Apr 7, 2023 · b39872a · b39872a
1 parent 7ae788d
commit b39872a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/primitive/message.go b/primitive/message.go
@@ -183,9 +183,12 @@ func (m *Message) WithTag(tags string) *Message {
 
 func (m *Message) WithKeys(keys []string) *Message {
 	var sb strings.Builder
-	for _, k := range keys {
+	for i, k := range keys {
 		sb.WriteString(k)
-		sb.WriteString(PropertyKeySeparator)
+		// avoid to append separator to the last key
+		if i < len(keys)-1 {
+			sb.WriteString(PropertyKeySeparator)
+		}
 	}
 
 	m.WithProperty(PropertyKeys, sb.String())

diff --git a/primitive/message_test.go b/primitive/message_test.go
@@ -36,3 +36,13 @@ func TestMessageID(t *testing.T) {
 	}
 	t.Log(msgID)
 }
+
+func TestMessageKey(t *testing.T) {
+	msg := &Message{}
+	expected := "testKey"
+	msg.WithKeys([]string{expected})
+	actual := msg.GetKeys()
+	if actual != expected {
+		t.Fatalf("get message key error: expected is '%s', actual is '%s'", expected, actual)
+	}
+}