[Pulsar client] Enable spotbugs in module pulsar-client. #9630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested changes
Feb 19, 2021
Comment on lines
1133
to
1132
| (op.cmd == null ? null : op.cmd.getClass().getName())); | ||
| log.warn("[{}] Failed while casting {} into ByteBufPair", producerName, null); |
There was a problem hiding this comment.
This will cause the log always print casting null?
There was a problem hiding this comment.
the op.cmd is always null, i will delete print it .
| @@ -49,7 +49,7 @@ | |||
| private transient ServiceUrlProvider serviceUrlProvider; | |||
|
|
|||
| @JsonIgnore | |||
| private Authentication authentication = AuthenticationDisabled.INSTANCE; | |||
| private Authentication authentication; | |||
There was a problem hiding this comment.
Why need to remove the default value?
There was a problem hiding this comment.
it has no any meaning.
public Authentication getAuthentication() {
if (authentication == null) {
this.authentication = new AuthenticationDisabled();
}
return authentication;
}
| @@ -66,7 +66,7 @@ public GenericAvroReader(Schema writerSchema, Schema readerSchema, byte[] schema | |||
| this.reader = new GenericDatumReader<>(writerSchema, readerSchema); | |||
| } | |||
| this.byteArrayOutputStream = new ByteArrayOutputStream(); | |||
| this.encoder = EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, encoder); | |||
| this.encoder = EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, null); | |||
There was a problem hiding this comment.
Use null will avoid reusing the encode?
There was a problem hiding this comment.
It doesn't make any sense, the encoder in this time is always null. same below.
| @@ -37,7 +37,7 @@ | |||
| public GenericAvroWriter(Schema schema) { | |||
| this.writer = new GenericDatumWriter<>(schema); | |||
| this.byteArrayOutputStream = new ByteArrayOutputStream(); | |||
| this.encoder = EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, encoder); | |||
| this.encoder = EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, null); | |||
There was a problem hiding this comment.
Same as the above comment.
| @@ -40,7 +40,7 @@ public AvroWriter(Schema schema) { | |||
|
|
|||
| public AvroWriter(Schema schema, boolean jsr310ConversionEnabled) { | |||
| this.byteArrayOutputStream = new ByteArrayOutputStream(); | |||
| this.encoder = EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, this.encoder); | |||
| this.encoder = EncoderFactory.get().binaryEncoder(this.byteArrayOutputStream, null); | |||
There was a problem hiding this comment.
Same as the above comment
codelipenghui
approved these changes
Feb 20, 2021
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Feb 22, 2021
- apache#9630 and apache#9329 were merged concurrently which caused the master branch to break - fixes SpotBugs error "Medium: org.apache.pulsar.client.impl.ConsumerBase.NONE_KEY should be package protected [org.apache.pulsar.client.impl.ConsumerBase] At ConsumerBase.java:[line 887] MS_PKGPROTECT"
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable spotbugs in module pulsar-client.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)