Cpp producer sequence id changes #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/feature
merlimat
force-pushed
the
producer-sequence-id
branch
from
6e92377
to
91dceed
Compare
rdhabalia
approved these changes
Sep 18, 2017
jai1
reviewed
Sep 18, 2017
| * <p> | ||
| * The sequence id can be used for deduplication purposes and it needs to follow these rules: | ||
| * <ol> | ||
| * <li><code>sequenceId >= 0</code> |
There was a problem hiding this comment.
Assertion for this - also why not use uint64_t
There was a problem hiding this comment.
Added check. Keeping int64_t for consistency with initialSequence id which can be negative.
| ProducerConfiguration& setSendTimeout(int sendTimeoutMs); | ||
| int getSendTimeout() const; | ||
|
|
||
| ProducerConfiguration& setInitialSequenceId(int64_t initialSequenceId); |
There was a problem hiding this comment.
can be -1 (default value)
saandrews
reviewed
Sep 18, 2017
| } | ||
|
|
||
| ProducerConfiguration& ProducerConfiguration::setInitialSequenceId(int64_t initialSequenceId) { | ||
| impl_->initialSequenceId = Optional<int64_t>::of(initialSequenceId); |
There was a problem hiding this comment.
Disallow negative value?
There was a problem hiding this comment.
Just noticed your earlier comment. Should we allow any negative in that case?
There was a problem hiding this comment.
Yes, initial can also be -1.
There was a problem hiding this comment.
I was referring to someone setting it to -10 for example. Do we have to reject any value less than -1? Ot it doesn't matter for us?
saandrews
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
C++ and Python equivalent of the Java client library changes made in #760
Last set of changes for PIP-6 implementation.
Changes in client side to expose sequence id in the
ProducerandMessageBuilderinterfaces.This change will enable applications to take advantage of deduplication and ensure messages can be stored only-once even after the producer application crashes or get restarted.
Modifications
ProducerConfigurationoptions:setProducerName()This was already used internally by replicator. Exposed in public APIsetInitialSequenceId()Let the application specify the initial sequence idProducerinterface:Producer.getLastSequenceId()to return the last persisted sequence id for a producerProducer.getProducerName()to access the auto-generated producer nameMessageBuilder.setSequenceId(): manually specify the sequence id of a message. This may be related to some application specific property