Pulsar Clients: Added a mandatory stop to the Backoff logic #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Sep 8, 2017
pulsar-client-cpp/lib/Backoff.cc
Outdated
| } | ||
|
|
||
| TimeDuration Backoff::next() { | ||
| TimeDuration current = next_; | ||
| next_ = std::min(next_ * 2, max_); | ||
|
|
||
| static TimeDuration timeElapsedSinceDisconnection_; |
There was a problem hiding this comment.
This is not working:
- Backoff has no notion of disconnection.. it's just a simple class to deal with exponential backoff
statichere is messing up across differentBackoffinstances. Each connection is having its own instance.
|
retest this please |
jai1
force-pushed
the
Backoff_new_approach
branch
from
ff3fb5b to
c4b321f
Compare
merlimat
reviewed
Sep 12, 2017
pulsar-client-cpp/lib/Backoff.h
Outdated
| TimeDuration mandatoryStop_; | ||
| TimeDuration timeElapsedSinceDisconnection_; | ||
| bool mandatoryStopMade_; | ||
| unsigned int seed_; |
pulsar-client-cpp/lib/Backoff.cc
Outdated
| current = std::max(initial_, mandatoryStop_ - timeElapsedSinceDisconnection_); | ||
| mandatoryStopMade_ = true; | ||
| } | ||
| timeElapsedSinceDisconnection_ += current; |
There was a problem hiding this comment.
Given that the exact current time might be slightly different than the "sleep" time, I think we should be better use an absolute time instead of timeElapsedSinceDisconnection_. That will be resistent to the multiple timeout being scheduled.
|
retest this please |
1 similar comment
|
retest this please |
jai1
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#745