Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navbar more mobile friendly #728

Merged
merged 7 commits into from
Sep 6, 2017
Merged

Make navbar more mobile friendly #728

merged 7 commits into from
Sep 6, 2017

Conversation

lucperkins
Copy link
Contributor

Motivation

At the moment, the website's navbar has a variety of UX problems on mobile, including sizing, overflow, and other issues.

Modifications

I've removed some CSS styling that either wasn't necessary or created a broken experience.

Result

The navbar will provide an experience more in line with what users will expect. Not perfect but I think a major improvement.

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat
Copy link
Contributor

retest this please

@lucperkins
Copy link
Contributor Author

@merlimat I'm getting this (non-website-related) error in CI:

[ERROR] Tests run: 542, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,225.036 s <<< FAILURE! - in TestSuite
[ERROR] socketTest(org.apache.pulsar.websocket.proxy.ProxyPublishConsumeTest)  Time elapsed: 0.198 s  <<< FAILURE!
java.lang.AssertionError: null: lists don't have the same size expected [6] but found [10]
	at org.apache.pulsar.websocket.proxy.ProxyPublishConsumeTest.socketTest(ProxyPublishConsumeTest.java:160)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   ProxyPublishConsumeTest.socketTest:160 null: lists don't have the same size expected [6] but found [10]
[INFO] 
[ERROR] Tests run: 542, Failures: 1, Errors: 0, Skipped: 0
[INFO] 
[ERROR] There are test failures.

Should I submit an issue?

@merlimat
Copy link
Contributor

merlimat commented Sep 6, 2017

Should I submit an issue?

There's already an issue open for that flaky test, though is not easy to replicate in local env.

@merlimat
Copy link
Contributor

merlimat commented Sep 6, 2017

retest this please

@merlimat merlimat merged commit 9c75f8f into apache:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants