-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make navbar more mobile friendly #728
Merged
merlimat
merged 7 commits into
apache:master
from
lucperkins:website/mobile-friendliness
Sep 6, 2017
Merged
Make navbar more mobile friendly #728
merlimat
merged 7 commits into
apache:master
from
lucperkins:website/mobile-friendliness
Sep 6, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Aug 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
retest this please |
@merlimat I'm getting this (non-website-related) error in CI:
Should I submit an issue? |
There's already an issue open for that flaky test, though is not easy to replicate in local env. |
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At the moment, the website's navbar has a variety of UX problems on mobile, including sizing, overflow, and other issues.
Modifications
I've removed some CSS styling that either wasn't necessary or created a broken experience.
Result
The navbar will provide an experience more in line with what users will expect. Not perfect but I think a major improvement.