Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python reader api #718

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Python reader api #718

merged 1 commit into from
Sep 13, 2017

Conversation

merlimat
Copy link
Contributor

Motivation

Add Python wrapper for the C++ reader API. This PR is based on #717, the relevant here is the 2nd commit. I'll rebase when first one is merged.

@merlimat merlimat added the type/feature The PR added a new feature or issue requested a new feature label Aug 28, 2017
@merlimat merlimat added this to the 1.20.0-incubating milestone Aug 28, 2017
@merlimat merlimat self-assigned this Aug 28, 2017
@merlimat
Copy link
Contributor Author

@jai1 @rdhabalia Rebased on master

@merlimat
Copy link
Contributor Author

Ping @rdhabalia @jai1

Copy link
Contributor

@jai1 jai1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested it but the code LGTM

@merlimat
Copy link
Contributor Author

Not tested it but the code LGTM

Unit tests are in. Next PR #722 will enable the python tests in build.

@merlimat merlimat merged commit 5cf010e into apache:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants