Feature - reset cursor on Reader to current position

[lovelle]

Motivation

There are some cases in which is it useful to be able to include current
position of message when reset of cursor was made.

This was reported by a vvy on slack, no issue has been created to track this.

Modifications

• Add startMessageIdInclusive() to support include current position of
  reset on ReaderBuilder.
• Add resetIncludeHead field for Reader and Consumer Configuration Data
• Fix position of cursor for non durable consumer.
• Improve discard if statement for batch enable mode.
• Add discard if statement for batch disable mode.
• Add test case to assert the start of specific message id at the expected
  position with data provider scenarios:
  A. Batch enable and start inclusive enable.
  B. Batch enable and start inclusive disable.
  C. Batch disable and start inclusive enable.
  D. Batch disable and start inclusive disable.

[jiazhai]

run java8 tests

[jiazhai]

lgtm. Indeed there is needs for this case.

[jiazhai]

@lovelle As @merlimat suggested, Would you please also help add a test parameter for batch/non-batch, this is a setting for producer config. So both batch and non-batch could be covered.

[lovelle]

@jiazhai Of course, I've just added, please take a look now, sorry for delay.

[jiazhai]

run cpp tests
run integration tests

[lovelle]

run cpp tests

[lovelle]

run cpp tests

[lovelle]

@jiazhai cpp tests keeps failing without notice of any failed tests, any hint on this? keep trying?

[lovelle]

run cpp tests

[jiazhai]

run cpp tests
run java8 tests

[jiazhai]

@lovelle right, seems no error in cpp, just timeout.

[141/153]Build timed out (after 200 minutes). Marking the build as aborted.

[jiazhai]

run cpp tests

[yjshen]

Python test failed:

2019-06-02 07:15:51.452 INFO  ConsumerImpl:170 | [persistent://public/default/my-string-python-topic, sub-1, 0] Created consumer on broker [127.0.0.1:48310 -> 127.0.0.1:6650] 
2019-06-02 07:15:51.473 INFO  ClientImpl:479 | Closing Pulsar client
2019-06-02 07:15:51.474 INFO  ProducerImpl:475 | [persistent://public/default/my-string-python-topic, standalone-0-219] Closing producer for topic persistent://public/default/my-string-python-topic
2019-06-02 07:15:51.474 INFO  ProducerImpl:475 | [persistent://public/default/my-string-python-topic, standalone-0-220] Closing producer for topic persistent://public/default/my-string-python-topic
2019-06-02 07:15:51.474 INFO  ConsumerImpl:839 | [persistent://public/default/my-string-python-topic, sub-1, 0] Closing consumer for topic persistent://public/default/my-string-python-topic
2019-06-02 07:15:51.474 INFO  ProducerImpl:513 | [persistent://public/default/my-string-python-topic, standalone-0-219] Closed producer
2019-06-02 07:15:51.474 INFO  ProducerImpl:513 | [persistent://public/default/my-string-python-topic, standalone-0-220] Closed producer
2019-06-02 07:15:51.475 INFO  ConsumerImpl:875 | [persistent://public/default/my-string-python-topic, sub-1, 0] Closed consumer 0
.
======================================================================
FAIL: test_reader_on_specific_message (__main__.PulsarTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "pulsar_test.py", line 395, in test_reader_on_specific_message
    self.assertEqual(msg.data(), b'hello-%d' % i)
AssertionError: 'hello-4' != 'hello-5'

----------------------------------------------------------------------
Ran 51 tests in 52.234s

[lovelle]

Ok, now I found it, let me explore this a little bit further

[sijie]

@lovelle I moved this to 2.5.0. if you think it should be 2.4.0, please let me know.

[jiazhai]

run cpp tests

[yjshen]

======================================================================
FAIL: test_reader_on_specific_message (__main__.PulsarTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "pulsar_test.py", line 403, in test_reader_on_specific_message
    self.assertEqual(msg.data(), b'hello-%d' % i)
AssertionError: 'hello-4' != 'hello-5'

----------------------------------------------------------------------
Ran 51 tests in 51.260s

Same error?

[lovelle]

run java8 tests

[lovelle]

@jiazhai @yjshen now is fixed, sorry for the trouble.

@sijie sure, no problem.

[merlimat]

👍

[sijie]

@jiazhai @yjshen can you check this pull request again since you left comments before?

[yjshen]

LGTM 👍