Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] Fix acknowledgeCumulativeAsync block when ackReceipt is enabled #23841

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

315157973
Copy link
Contributor

@315157973 315157973 commented Jan 12, 2025

Motivation

Repeated calls to acknowledgeCumulativeAsync will block, when AckReceipt is enabled.

Modifications

Request only sent when MessageID increases.
Therefore, CompletableFuture returned by PersistentAcknowledgmentsGroupingTracker will not be completed.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: 315157973#16

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 12, 2025
@315157973 315157973 self-assigned this Jan 12, 2025
@congbobo184 congbobo184 added this to the 4.1.0 milestone Jan 13, 2025
@BewareMyPower BewareMyPower merged commit 999db2c into apache:master Jan 14, 2025
62 of 64 checks passed
lhotari pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants