-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Skip to persist cursor info if it failed by cursor closed #23615
[fix][broker] Skip to persist cursor info if it failed by cursor closed #23615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close reopen to retrigger the ci |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23615 +/- ##
============================================
+ Coverage 73.57% 74.15% +0.58%
+ Complexity 32624 32145 -479
============================================
Files 1877 1853 -24
Lines 139502 143376 +3874
Branches 15299 16277 +978
============================================
+ Hits 102638 106322 +3684
+ Misses 28908 28682 -226
- Partials 7956 8372 +416
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@poorbarcode pls resolve the ci failure |
Sure |
…ed (apache#23615) (cherry picked from commit 9850605) (cherry picked from commit 86eb2a8)
…ed (apache#23615) (cherry picked from commit 9850605) (cherry picked from commit 86eb2a8)
Motivation
We encountered an issue as follows
closing topic -> closing curosr
in-progress cursor mark deleting
54781383
54781383
54781383
is closed in memory54781383
, but the ledger was marked closed54781383
to ZKI think we need at least
3
fixesModifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x