Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client] Add more info while throwing reader creation exception #23401

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Oct 4, 2024

Motivation

Currently it's difficult for client to troubleshoot when Reader creation fails as it error doesn't provide enough information so, create error with more information to help client for troubleshooting.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/client doc-not-needed Your PR changes do not impact docs ready-to-test labels Oct 4, 2024
@rdhabalia rdhabalia self-assigned this Oct 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (bbc6224) to head (3ecd85e).
Report is 636 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23401      +/-   ##
============================================
+ Coverage     73.57%   74.53%   +0.96%     
+ Complexity    32624     2755   -29869     
============================================
  Files          1877     1937      +60     
  Lines        139502   145435    +5933     
  Branches      15299    15897     +598     
============================================
+ Hits         102638   108407    +5769     
+ Misses        28908    28703     -205     
- Partials       7956     8325     +369     
Flag Coverage Δ
inttests 27.76% <0.00%> (+3.18%) ⬆️
systests 24.53% <0.00%> (+0.20%) ⬆️
unittests 73.88% <100.00%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/apache/pulsar/client/impl/ReaderBuilderImpl.java 85.56% <100.00%> (+0.46%) ⬆️

... and 614 files with indirect coverage changes

@rdhabalia rdhabalia merged commit 6bca70b into apache:master Oct 4, 2024
53 of 55 checks passed
@rdhabalia rdhabalia deleted the vm_nic branch October 4, 2024 23:09
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants