Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc] Fix some typos in pip #23288

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pip/pip-307.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ sequenceDiagram
Leader Broker ->> Owner Broker: "state:Releasing:" close topic
Owner Broker ->> Owner Broker: close broker topic sessions
Owner Broker ->> Clients: close producers and consumers
Clients ->> Clients: reconnecting (inital delay 100ms)
Clients ->> Clients: reconnecting (initial delay 100ms)
Owner Broker ->> New Owner Broker: "state:Assign:" assign new ownership
New Owner Broker ->> Owner Broker: "state:Owned:" ack new ownership
Clients ->> Owner Broker: lookup
Expand Down
4 changes: 2 additions & 2 deletions pip/pip-324-Alpine Docker images.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
Pulsar Docker images are currently based on Ubuntu base images. While these images has served us well in the past years,
there are few shortcomings.

Alpine Linux is a Linux distribution designed explicitely to work well in container environments and has strong
focus on security and a minimalistic set of included depedendencies.
Alpine Linux is a Linux distribution designed explicitly to work well in container environments and has strong
focus on security and a minimalistic set of included dependencies.

### Size of the image

Expand Down
6 changes: 3 additions & 3 deletions pip/pip-337.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public interface PulsarSslFactory extends AutoCloseable {

/*
* Returns the internally stored ssl context
* @throws IllegalStateException If the SSL Context has not be created before this call, then it wil throw this
* @throws IllegalStateException If the SSL Context has not be created before this call, then it will throw this
* exception.
*/
SSLContext getInternalSslContext();
Expand Down Expand Up @@ -214,7 +214,7 @@ public class DefaultPulsarSslFactory implements PulsarSslFactory {
}
```

### Pulsar Commmon Changes
### Pulsar Common Changes

4 new configurations will need to be added into the Configurations like `ServiceConfiguration`,
`ClientConfigurationData`, `ProxyConfiguration`, etc. All of the below will be optional. It will use the default values
Expand Down Expand Up @@ -360,7 +360,7 @@ the DefaultAsyncHttpClient. This pattern will be common across all HTTP Clients

### Configuration

Same as [Broker Common Changes](#pulsar-commmon-changes)
Same as [Broker Common Changes](#pulsar-common-changes)

### CLI
CLI tools like `PulsarClientTool` and `PulsarAdminTool` will need to be modified to support the new configurations.
Expand Down
2 changes: 1 addition & 1 deletion pip/pip-352.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ the Pulsar topic in a different order than intended. Implementing event
time-based checks could mitigate this inconvenience.

# Goals
* No impact on current topic compation behavior
* No impact on current topic compaction behavior
* Preserve the order of messages during compaction regardless of network latencies

## In Scope
Expand Down
4 changes: 2 additions & 2 deletions pip/pip-359.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Implementation PR: [#22861](https://github.com/apache/pulsar/pull/22861)
# Background knowledge
In the current Pulsar client versions, from the user's perspective, when using a Pulsar Consumer,
we have two main options to consume messages:
1. Pull mode, by calling `consumer.recieve()`(or `consumer.recieveAsync()`)
1. Pull mode, by calling `consumer.receive()`(or `consumer.receiveAsync()`)
```java
public class ConsumerExample {
public static void main(String[] args) throws PulsarClientException {
Expand All @@ -25,7 +25,7 @@ public class ConsumerExample {

```
2. Push mode, by registering a `MessageListener` interface, when building the Consumer.
When this method is used, we can't also use `consumer.receive()`(or `consumer.recieveAsync()`).
When this method is used, we can't also use `consumer.receive()`(or `consumer.receiveAsync()`).
In the push mode, the MessageListener instance is called by the consumer, hence it is
doing that with a thread taken from its own internal `ExecutorService` (i.e. thread pool).
The problem comes when we build and use multiple Consumers from the same PulsarClient. It
Expand Down
2 changes: 1 addition & 1 deletion pip/pip-368.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ message CommandLookupTopic {
}
```

When the client lookups a topic, it will set the client `lookupPorperties` to the `CommandLookupTopic.properties`.
When the client lookups a topic, it will set the client `lookupProperties` to the `CommandLookupTopic.properties`.

### Public API

Expand Down
Loading