Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Upgrade docker-maven-plugin to 0.45.0 #23091

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Jul 29, 2024

Motivation

docker-maven-plugin keeps up to the latest version.

Modifications

  • Improve docker-push profile
  • Remove tag goal, because build goal includes tag feature
  • Upgrade docker-maven-plugin to 0.45.0

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece self-assigned this Jul 29, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 29, 2024
@lhotari
Copy link
Member

lhotari commented Jul 29, 2024

@nodece does this make #22754 and #22609 obsolete? Please close them in that case.

I forgot the reason why the tag goal is removed. please add a description.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (bbc6224) to head (202a701).
Report is 471 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23091      +/-   ##
============================================
- Coverage     73.57%   73.45%   -0.13%     
- Complexity    32624    33511     +887     
============================================
  Files          1877     1917      +40     
  Lines        139502   144067    +4565     
  Branches      15299    15741     +442     
============================================
+ Hits         102638   105818    +3180     
- Misses        28908    30125    +1217     
- Partials       7956     8124     +168     
Flag Coverage Δ
inttests 27.51% <ø> (+2.92%) ⬆️
systests 24.80% <ø> (+0.47%) ⬆️
unittests 72.51% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 513 files with indirect coverage changes

@nodece
Copy link
Member Author

nodece commented Jul 29, 2024

@lhotari Thanks, Done.

@lhotari lhotari merged commit 76ed555 into apache:master Jul 29, 2024
53 of 56 checks passed
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece nodece deleted the upgrade-docker-maven-plugin branch July 29, 2024 11:19
@lhotari
Copy link
Member

lhotari commented Jul 29, 2024

@nodece One of the problems with the profile refactoring is that it breaks the current release process documented at https://pulsar.apache.org/contribute/release-process/#release-pulsar-30-and-later. I think that it would be better to revert the changes related to moving the profile to docker/pom.xml since many might have internal releases that break as a result.

@nodece
Copy link
Member Author

nodece commented Jul 29, 2024

If we push the image in the docker/pulsar or docker/pulsar-all directory, this PR will break the release process, otherwise, it works fine in the docker directory.

Usually, we will push images in the docker directory, what do you think?

@lhotari
Copy link
Member

lhotari commented Jul 29, 2024

If we push the image in the docker/pulsar or docker/pulsar-all directory, this PR will break the release process, otherwise, it works fine in the docker directory.

Usually, we will push images in the docker directory, what do you think?

well, the release process uses -pl docker/pulsar,docker/pulsar-all. It will break. Many others might have copied the similar command that is used in https://pulsar.apache.org/contribute/release-process/#release-pulsar-30-and-later .

@nodece
Copy link
Member Author

nodece commented Jul 29, 2024

@lhotari #23093 will fix that.

nodece added a commit to ascentstream/pulsar that referenced this pull request Aug 28, 2024
Signed-off-by: Zixuan Liu <[email protected]>

(cherry picked from commit 76ed555)
Signed-off-by: Zixuan Liu <[email protected]>
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
nodece added a commit to ascentstream/pulsar that referenced this pull request Oct 17, 2024
Signed-off-by: Zixuan Liu <[email protected]>

(cherry picked from commit 76ed555)
Signed-off-by: Zixuan Liu <[email protected]>
nodece added a commit to nodece/pulsar that referenced this pull request Oct 24, 2024
Signed-off-by: Zixuan Liu <[email protected]>

(cherry picked from commit 76ed555)
Signed-off-by: Zixuan Liu <[email protected]>
nodece added a commit that referenced this pull request Oct 29, 2024
Signed-off-by: Zixuan Liu <[email protected]>

(cherry picked from commit 76ed555)
Signed-off-by: Zixuan Liu <[email protected]>
nodece added a commit to ascentstream/pulsar that referenced this pull request Dec 3, 2024
Signed-off-by: Zixuan Liu <[email protected]>

(cherry picked from commit 76ed555)
Signed-off-by: Zixuan Liu <[email protected]>
nodece added a commit to ascentstream/pulsar that referenced this pull request Jan 7, 2025
Signed-off-by: Zixuan Liu <[email protected]>

(cherry picked from commit 76ed555)
Signed-off-by: Zixuan Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants