-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][build] Upgrade docker-maven-plugin to 0.45.0 #23091
Conversation
Signed-off-by: Zixuan Liu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23091 +/- ##
============================================
- Coverage 73.57% 73.45% -0.13%
- Complexity 32624 33511 +887
============================================
Files 1877 1917 +40
Lines 139502 144067 +4565
Branches 15299 15741 +442
============================================
+ Hits 102638 105818 +3180
- Misses 28908 30125 +1217
- Partials 7956 8124 +168
Flags with carried forward coverage won't be shown. Click here to find out more. |
@lhotari Thanks, Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nodece One of the problems with the profile refactoring is that it breaks the current release process documented at https://pulsar.apache.org/contribute/release-process/#release-pulsar-30-and-later. I think that it would be better to revert the changes related to moving the profile to docker/pom.xml since many might have internal releases that break as a result. |
If we push the image in the docker/pulsar or docker/pulsar-all directory, this PR will break the release process, otherwise, it works fine in the docker directory. Usually, we will push images in the docker directory, what do you think? |
well, the release process uses |
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 76ed555) Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 76ed555) Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 76ed555) Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 76ed555) Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 76ed555) Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 76ed555) Signed-off-by: Zixuan Liu <[email protected]>
Motivation
docker-maven-plugin keeps up to the latest version.
Modifications
docker-push
profileDocumentation
doc
doc-required
doc-not-needed
doc-complete