Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add transaction metrics #22970

Merged

Conversation

dragosvictor
Copy link
Contributor

PIP-264

Motivation

Adds the transaction metrics as described by https://pulsar.apache.org/docs/next/reference-metrics/#pulsar-transaction to the OpenTelemetry pipeline.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

This change updated tests and can be verified as follows:

  • Updated test TransactionTest#testTopicTransactionMetrics
  • Updated test TopicTransactionBufferTest#testTransactionBufferAppendMarkerWriteFailState
  • Updated test PendingAckPersistentTest#testPendingAckMetrics

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: dragosvictor#37

@dragosvictor dragosvictor marked this pull request as ready for review June 24, 2024 19:06
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jun 24, 2024
@dragosvictor dragosvictor changed the title Dmisca pip 264 transaction metrics [feat][broker] PIP-264: Add transaction metrics Jun 24, 2024
@merlimat merlimat added this to the 3.4.0 milestone Jun 25, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one question

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 20 lines in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (bbc6224) to head (34aae58).
Report is 603 commits behind head on master.

Files with missing lines Patch % Lines
.../buffer/impl/TransactionBufferClientStatsImpl.java 81.48% 3 Missing and 2 partials ⚠️
...ion/pendingack/impl/PendingAckHandleStatsImpl.java 81.81% 2 Missing and 2 partials ⚠️
...oordinator/impl/InMemTransactionMetadataStore.java 33.33% 4 Missing ⚠️
...n/java/org/apache/pulsar/broker/PulsarService.java 80.00% 2 Missing ⚠️
.../OpenTelemetryTransactionPendingAckStoreStats.java 93.33% 0 Missing and 2 partials ⚠️
...tats/OpenTelemetryTransactionCoordinatorStats.java 96.77% 0 Missing and 1 partial ⚠️
...nsaction/coordinator/TransactionMetadataStore.java 0.00% 1 Missing ⚠️
...n/coordinator/impl/MLTransactionMetadataStore.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22970      +/-   ##
============================================
- Coverage     73.57%   73.37%   -0.21%     
- Complexity    32624    33236     +612     
============================================
  Files          1877     1905      +28     
  Lines        139502   142763    +3261     
  Branches      15299    15579     +280     
============================================
+ Hits         102638   104751    +2113     
- Misses        28908    29993    +1085     
- Partials       7956     8019      +63     
Flag Coverage Δ
inttests 27.42% <47.16%> (+2.84%) ⬆️
systests 24.66% <6.41%> (+0.33%) ⬆️
unittests 72.41% <92.45%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lsar/broker/service/PersistentTopicAttributes.java 100.00% <100.00%> (ø)
...ker/service/persistent/PersistentSubscription.java 76.90% <100.00%> (+0.21%) ⬆️
...ker/service/persistent/PersistentTopicMetrics.java 100.00% <100.00%> (ø)
...e/pulsar/broker/stats/OpenTelemetryTopicStats.java 99.56% <100.00%> (ø)
...ansaction/buffer/TransactionBufferClientStats.java 25.00% <100.00%> (ø)
...ction/buffer/impl/TransactionBufferClientImpl.java 83.72% <100.00%> (ø)
...saction/pendingack/PendingAckHandleAttributes.java 100.00% <100.00%> (ø)
.../transaction/pendingack/PendingAckHandleStats.java 100.00% <ø> (ø)
...tion/pendingack/impl/PendingAckHandleDisabled.java 33.33% <100.00%> (+3.92%) ⬆️
...nsaction/pendingack/impl/PendingAckHandleImpl.java 72.63% <100.00%> (+1.78%) ⬆️
... and 10 more

... and 456 files with indirect coverage changes

@merlimat merlimat merged commit 4e535cb into apache:master Jun 27, 2024
50 of 51 checks passed
@dragosvictor dragosvictor deleted the dmisca-pip-264-transaction-metrics branch June 27, 2024 16:46
shibd added a commit to shibd/pulsar that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants