[improve][broker] Optimize ConcurrentOpenLongPairRangeSet by RoaringBitmap
#22908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please upgrade RoaringBitmap to latest version 1.0.6. it contains useful improvements such as RoaringBitmap/RoaringBitmap#713. |
Thanks for reminding, I'll create another PR to do the upgrading |
The new features could be useful in this PR. That's why it could be useful to simply do in this PR. |
|
@lhotari @mattisonchao @shibd PTAL |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2024
…gBitmap (apache#22908) (cherry picked from commit 5b1f653) (cherry picked from commit f99040d)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…gBitmap (apache#22908) (cherry picked from commit 5b1f653) (cherry picked from commit f99040d)
|
I have reverted the changes in branch-3.0 branch-3.2 and branch-3.3 due to regressions referred in #22966 |
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Jun 24, 2024
…Set` by RoaringBitmap (apache#22908)" This reverts commit 5b1f653.
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…gBitmap (apache#22908) (cherry picked from commit 5b1f653) (cherry picked from commit f99040d)
15 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
…y RoaringBitmap (apache#22908)" This reverts commit f99040d. (cherry picked from commit 266f98c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…gBitmap (apache#22908) (cherry picked from commit 5b1f653) (cherry picked from commit f99040d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…y RoaringBitmap (apache#22908)" This reverts commit f99040d. (cherry picked from commit 266f98c)
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22866
Motivation
Optimize ConcurrentOpenLongPairRangeSet to prevent long GC pause
Modifications
RoaringBitmapversion to 1.1.0org.roaringbitmap.RoaringBitSetConcurrentRoaringBitSetextendsorg.roaringbitmap.RoaringBitSetto make it concurrency.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: