[improve][fn] Support subscriptionPosition and DLQ for Go instance #22457
Conversation
pulsar-function-go/pf/instance.go
Outdated
| if retryDetails.MaxMessageRetries >= 0 { | ||
| dlqPolicy.MaxDeliveries = uint32(retryDetails.MaxMessageRetries) | ||
| } | ||
| retryEnable = true |
There was a problem hiding this comment.
isn't RetryEnable related to having RetryLetterTopic defined?
I'd assume that DeadLetterTopic can be set without setting RetryEnable.
There was a problem hiding this comment.
oh, it doesn't seem to be the case in pulsar-client-go: https://github.com/apache/pulsar-client-go/blob/393f80b4b93faa36936380b643426026a2b2cd02/pulsar/consumer_impl.go#L116-L168
In the Java client, this is different. It seems to make sense that DLQ feature is independent of retrying, but that's not how pulsar-client-go is implemented.
There was a problem hiding this comment.
seems it's more reasonable to leave RetryEnable to false here, then it just won't set the default DeadLetterTopic
lhotari
dismissed
their stale review
Dismissing my review since I made an invalid assumption of pulsar-client-go.
Fixes #22445
Main Issue: #xyz
PIP: #xyz
Motivation
Modifications
Support subscriptionPosition and DLQ for Go instance
Verifying this change
Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#32