-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Add createTopicIfDoesNotExist option to RawReader constructor #22264
Merged
nodece
merged 1 commit into
apache:master
from
coderzc:improve_RawReader_autocreatetopic
Mar 14, 2024
Merged
[improve][broker] Add createTopicIfDoesNotExist option to RawReader constructor #22264
nodece
merged 1 commit into
apache:master
from
coderzc:improve_RawReader_autocreatetopic
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
approved these changes
Mar 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22264 +/- ##
============================================
+ Coverage 73.57% 73.61% +0.03%
- Complexity 32624 32740 +116
============================================
Files 1877 1879 +2
Lines 139502 139795 +293
Branches 15299 15340 +41
============================================
+ Hits 102638 102906 +268
+ Misses 28908 28903 -5
- Partials 7956 7986 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codelipenghui
approved these changes
Mar 14, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Mar 15, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Mar 15, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…onstructor (apache#22264) (cherry picked from commit 16cf199)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…onstructor (apache#22264) (cherry picked from commit 16cf199)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…onstructor (apache#22264) (cherry picked from commit 16cf199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-3.0
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.4
release/3.2.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #21745, we disabled the createTopicIfDoesNotExists of RawReader to avoid the compactor‘s RawReader will create the topic again after the topic has been deleted.
Because the RawReader is a public API, so we'd better not change the default behavior. we can add an option for RawReader.
Modifications
Add createTopicIfDoesNotExist option to RawReader constructor.
Revert RawReader to default behavior (auto create topic)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: