Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest #22252

Merged
merged 3 commits into from
Mar 12, 2024
Merged

[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest #22252

merged 3 commits into from
Mar 12, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 12, 2024 •
edited
Loading

Fixes #17126

Motivation

RGUsageMTAggrWaitForAllMsgsTest is flaky

Modifications

  • wait until the consumer thread completes before reading the counters
  • make fields volatile (however this might not be necessary since thread is joined before reading fields)
  • move the tests to flaky tests since it remains flaky after the above modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone Mar 12, 2024
@lhotari lhotari requested a review from Technoboy- March 12, 2024 13:55
@lhotari lhotari self-assigned this Mar 12, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 12, 2024
@lhotari lhotari merged commit 43f9d2a into apache:master Mar 12, 2024
51 checks passed
lhotari added a commit that referenced this pull request Mar 27, 2024
@lhotari
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (#22252)
6e0ebcb 
(cherry picked from commit 43f9d2a)
lhotari added a commit that referenced this pull request Mar 27, 2024
@lhotari
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (#22252)
21e5695 
(cherry picked from commit 43f9d2a)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2024
@lhotari @mukesh-ctds
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (apache#22252)
3c23135 
(cherry picked from commit 43f9d2a)
(cherry picked from commit 6e0ebcb)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
@lhotari @mukesh-ctds
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (apache#22252)
f92b2b0 
(cherry picked from commit 43f9d2a)
(cherry picked from commit 6e0ebcb)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
@lhotari @mukesh-ctds
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (apache#22252)
bbb0900 
(cherry picked from commit 43f9d2a)
(cherry picked from commit 6e0ebcb)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
@lhotari @mukesh-ctds
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (apache#22252)
0a4bd3d 
(cherry picked from commit 43f9d2a)
(cherry picked from commit 6e0ebcb)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
@lhotari @srinath-ctds
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (apache#22252)
b54b249 
(cherry picked from commit 43f9d2a)
(cherry picked from commit 6e0ebcb)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 14, 2024
@lhotari @nodece
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (apache#22252)
85dab6c 
(cherry picked from commit 43f9d2a)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 15, 2024
@lhotari @nodece
[fix][test] Fix flaky RGUsageMTAggrWaitForAllMsgsTest (apache#22252)
80ae6b1 
(cherry picked from commit 43f9d2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes

@nodece nodece nodece approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

Assignees

@lhotari lhotari

Labels
cherry-picked/branch-3.0 cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.4 release/3.2.2 type/flaky-tests
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Flaky-test: RGUsageMTAggrWaitForAllMsgsTest.testMTProduceConsumeRGUsageNonPersistentTopicNamesSameTenant
3 participants
@lhotari @nodece @liangyepianzhou