Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Support not retaining null-key message during topic compaction (#21578) #21662

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Dec 4, 2023

Motivation & Modifications

Cherry-pick #21578 into branch-3.0 with topicCompactionRetainNullKey=true default.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 4, 2023
@coderzc coderzc changed the title [branch-3.0][improve][broker] Support not retaining null-key message during topic compaction (#21578) [improve][broker][branch-3.0] Support not retaining null-key message during topic compaction (#21578) Dec 4, 2023
@coderzc coderzc closed this Dec 4, 2023
@coderzc coderzc reopened this Dec 4, 2023
@Technoboy- Technoboy- changed the title [improve][broker][branch-3.0] Support not retaining null-key message during topic compaction (#21578) [improve][broker] Support not retaining null-key message during topic compaction (#21578) Dec 4, 2023
@Technoboy- Technoboy- merged commit 744b7af into apache:branch-3.0 Dec 4, 2023
67 of 71 checks passed
@RobertIndie
Copy link
Member

What is the motivation for cherry-picking this to branch-3.0? This changes the default configuration value and should be considered an important notice.
We shouldn't bring this change to LTS version unless we have a strong motivation for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants