-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-320: OpenTelemetry Scaffolding #21635
Conversation
@asafm Please add the following content to your PR description and select a checkbox:
|
I left some comments. Asked questions I was interested in during the reading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small clarifications needed. Overall looks good.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lhotari The vote has been concluded and approved. Can you merge it? |
Motivation
Adding PIP-320, which a sub-PIP of PIP-264 (Implementation tracked at #21121).
This PIP is about adding the infrastructure to use OpenTelemetry in Pulsar broker, proxy and function worker.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete