-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Fix multiple thread leaks in tests, part 3 #21543
Merged
lhotari
merged 15 commits into
apache:master
from
lhotari:lh-fix-even-more-thread-leaks-in-tests-3
Nov 8, 2023
Merged
[fix][test] Fix multiple thread leaks in tests, part 3 #21543
lhotari
merged 15 commits into
apache:master
from
lhotari:lh-fix-even-more-thread-leaks-in-tests-3
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-fix-even-more-thread-leaks-in-tests-3
branch
from
November 8, 2023 10:50
3b42751
to
7f48960
Compare
Codecov Report
@@ Coverage Diff @@
## master #21543 +/- ##
=============================================
+ Coverage 36.57% 73.23% +36.65%
- Complexity 12205 32673 +20468
=============================================
Files 1715 1892 +177
Lines 131092 140702 +9610
Branches 14300 15478 +1178
=============================================
+ Hits 47952 103047 +55095
+ Misses 76759 29545 -47214
- Partials 6381 8110 +1729
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tisonkun
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Demogorgon314
approved these changes
Nov 8, 2023
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are thread leaks in tests reported by the thread leak detection added in #21450.
Modifications
Fix multiple thread leaks in unit tests.
Documentation
doc
doc-required
doc-not-needed
doc-complete