Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fixed too short wait in ResourceGroupRateLimiterTest #21509

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Nov 3, 2023

Fixes #20385

Motivation

The test wait time is too short.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.2.0 milestone Nov 3, 2023
@merlimat merlimat self-assigned this Nov 3, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 3, 2023
@merlimat merlimat changed the title Fixed too short wait in ResourceGroupRateLimiterTest [fix] Fixed too short wait in ResourceGroupRateLimiterTest Nov 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #21509 (01919db) into master (78fc853) will increase coverage by 39.87%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21509       +/-   ##
=============================================
+ Coverage     33.39%   73.27%   +39.87%     
- Complexity    12194    32612    +20418     
=============================================
  Files          1638     1890      +252     
  Lines        127949   140440    +12491     
  Branches      13952    15436     +1484     
=============================================
+ Hits          42733   102901    +60168     
+ Misses        79564    29454    -50110     
- Partials       5652     8085     +2433     
Flag Coverage Δ
inttests 24.19% <ø> (+0.04%) ⬆️
systests 24.78% <ø> (?)
unittests 72.54% <ø> (+40.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1538 files with indirect coverage changes

@lhotari lhotari changed the title [fix] Fixed too short wait in ResourceGroupRateLimiterTest [fix][test] Fixed too short wait in ResourceGroupRateLimiterTest Nov 3, 2023
@lhotari lhotari merged commit d47637f into apache:master Nov 3, 2023
53 checks passed
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky-test: ResourceGroupRateLimiterTest.testResourceGroupPublishRateLimit
3 participants