Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][client] Introduce Refresh API in the TableView #21417

Merged
merged 11 commits into from
Mar 15, 2024

Conversation

liangyepianzhou
Copy link
Contributor

Master #21271

Motivation

The proposal will introduce a new API to refresh the table view with the latest written data on the topic, ensuring that all subsequent reads are based on the refreshed data.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 23, 2023
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove meaningless lines

1. Add refresh API.
2. Add a linkedHashMap storing the refresh request.
2.1 Add request when refresh
2.2 Complete request when read completely.
2.3 Complete request exceptionally when reader close.
3. Add a map storing the current read position.
4. Check the current read position when building new refresh request.
@BewareMyPower
Copy link
Contributor

@codelipenghui Could you take a second review again?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.36066% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.64%. Comparing base (bbc6224) to head (7fc7a34).
Report is 54 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21417      +/-   ##
============================================
+ Coverage     73.57%   73.64%   +0.06%     
+ Complexity    32624    32258     -366     
============================================
  Files          1877     1887      +10     
  Lines        139502   139436      -66     
  Branches      15299    15292       -7     
============================================
+ Hits         102638   102681      +43     
+ Misses        28908    28820      -88     
+ Partials       7956     7935      -21     
Flag Coverage Δ
inttests 26.88% <29.50%> (+2.30%) ⬆️
systests 24.37% <0.00%> (+0.04%) ⬆️
unittests 72.91% <98.36%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/apache/pulsar/client/impl/TableViewImpl.java 88.82% <98.36%> (+3.51%) ⬆️

... and 161 files with indirect coverage changes

@liangyepianzhou liangyepianzhou merged commit 95d24ac into apache:master Mar 15, 2024
50 checks passed
@liangyepianzhou liangyepianzhou deleted the refresh branch March 15, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants