[fix][sec] Upgrade prometheus client_golang to v1.12.2 to fix CVE-2022-21698 #20579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ericsyh <[email protected]>
|
@codelipenghui @freeznet PTAL |
freeznet
approved these changes
Jun 15, 2023
ericsyh
changed the title
tisonkun
approved these changes
Jun 16, 2023
Codecov Report
@@ Coverage Diff @@
## master #20579 +/- ##
=============================================
+ Coverage 31.93% 73.01% +41.08%
- Complexity 11776 31978 +20202
=============================================
Files 1498 1867 +369
Lines 114571 138636 +24065
Branches 12422 15231 +2809
=============================================
+ Hits 36583 101220 +64637
+ Misses 73149 29383 -43766
- Partials 4839 8033 +3194
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Merging... Thank you! I wonder what versions are expected to be cherry-picked. |
tisonkun
changed the title
I think 3.0, 2.11, and 2.10 active branches should cherry-pick this PR. |
15 tasks
This was referenced Mar 12, 2024
lhotari
pushed a commit
that referenced
this pull request
Mar 27, 2024
…2-21698 (#20579) Signed-off-by: ericsyh <[email protected]> (cherry picked from commit a85e9df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Master Issue: #xyz
PIP: #xyz
Motivation
Prometheus client_golang v1.11.1 is impacted by the CVE-2022-21698
Modifications
Upgrade the Prometheus client_golang to v1.12.2
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
My local repo CI result:
https://github.com/ericsyh/pulsar/pull/2