[fix][broker] Fix redirect loop when using ExtensibleLoadManager and list in bundle admin API #20528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
added
type/bug
eolivelli
approved these changes
Jun 7, 2023
| @@ -1108,19 +1108,7 @@ public Set<NamespaceBundle> getOwnedServiceUnits() { | |||
| } | |||
|
|
|||
| public boolean isServiceUnitOwned(ServiceUnitId suName) throws Exception { | |||
There was a problem hiding this comment.
as a follow up work we should remove this synchronous method
There was a problem hiding this comment.
Yes, let's address it in another PR.
Demogorgon314
requested review from
Technoboy-,
gaoran10,
BewareMyPower and
mattisonchao
heesung-sn
approved these changes
Jun 7, 2023
| @@ -1108,19 +1108,7 @@ public Set<NamespaceBundle> getOwnedServiceUnits() { | |||
| } | |||
|
|
|||
| public boolean isServiceUnitOwned(ServiceUnitId suName) throws Exception { | |||
| if (suName instanceof TopicName) { | |||
| return isTopicOwnedAsync((TopicName) suName).get(); | |||
There was a problem hiding this comment.
Are we safe to skip these checks?
There was a problem hiding this comment.
Yes, you can see the isServiceUnitOwnedAsync method has the same checks.
gaoran10
approved these changes
Jun 8, 2023
mattisonchao
approved these changes
Jun 8, 2023
codelipenghui
approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #20528 +/- ##
=============================================
+ Coverage 36.82% 72.92% +36.09%
- Complexity 12040 31905 +19865
=============================================
Files 1690 1867 +177
Lines 128968 138548 +9580
Branches 14036 15216 +1180
=============================================
+ Hits 47493 101034 +53541
+ Misses 75220 29490 -45730
- Partials 6255 8024 +1769
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
pushed a commit
that referenced
this pull request
Jun 14, 2023
…list in bundle admin API (#20528) PIP: #16691 When using `ExtensibleLoadManager` and list in bundle admin API, it will redirect forever because `isServiceUnitOwned` method is checking the `ownershipCache` as the ownership storage, however, when using `ExtensibleLoadManager`, it stored the ownership to table view. * Call `isServiceUnitOwnedAsync ` when using `isServiceUnitOwned `. * Add unit test to cover this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16691
Motivation
When using
ExtensibleLoadManagerand list in bundle admin API,it will redirect forever because
isServiceUnitOwnedmethod is checking theownershipCacheas the ownership storage, however, when usingExtensibleLoadManager, it stored the ownership to table view.Modifications
isServiceUnitOwnedAsyncwhen usingisServiceUnitOwned.Documentation
docdoc-requireddoc-not-neededdoc-complete