-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] log update in class:LeastResourceUsageWithWeight #20168
Conversation
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New loadbalancer has always been print info
log with this flag.
@heesung-sn help me review it ,thanks |
We print info logs under the debugMode flag. Whats the intention? |
@heesung-sn In your PR #18964 ,you print info log in debugMode flag, |
The intention about the info logs under this debugMode flag is to dynamically print the useful operational logs when there are issues and monitor the decision logics, without restarting brokers. One can turn off this debug mode, when done. With this dynamic flag, one may not need to change the log level as it currently outputs logs at the info level. I understand some other projects strictly matches log levels in config and code. However, it appears that Pulsar does not have such strict practice as we have other code that prints info level logs under some debug flags(e.g log.isDebugEnabled). I would let Pulsar PMC members decide on such practice, and we follow it. |
The pr had no activity for 30 days, mark with Stale label. |
Closed as no consensus. There is no relation between |
Motivation
base PR: #18964 ,log update in class(org.apache.pulsar.broker.loadbalance.extensions.strategy.LeastResourceUsageWithWeight)
Modifications
when log's level is debug,call log.debug to print log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: StevenLuMT#9