[fix][client] Fix breaking changes for the deprecated methods of TopicMessageIdImpl #20163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
eolivelli,
codelipenghui,
RobertIndie,
Demogorgon314,
nicoloboschi and
poorbarcode
cbornet
added
the
release/blocker
cbornet
approved these changes
Apr 21, 2023
codelipenghui
approved these changes
Apr 21, 2023
Demogorgon314
approved these changes
Apr 21, 2023
RobertIndie
approved these changes
Apr 21, 2023
lifepuzzlefun
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#19414 introduces a breaking change for the deprecated
TopicMessageIdImpl#getInnerMessageIdmethod. It does not return the inner message id, instead, it creates a newMessageIdImpl.Modifications
Fix the
getInnerMessageIdmethod and add tests for these deprecated methods.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#28