-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Make timer execute immediately after load index #20126
Conversation
@coderzc we're in code freeze for 3.0. Is this a blocker or fixing a regression from 2.11 ? Otherwise I suggest to move this to 3.1 milestone. |
OK, it can be moved to 3.1 |
Codecov Report
@@ Coverage Diff @@
## master #20126 +/- ##
=============================================
+ Coverage 37.75% 72.95% +35.20%
- Complexity 12534 31920 +19386
=============================================
Files 1691 1868 +177
Lines 128811 138359 +9548
Branches 14045 15226 +1181
=============================================
+ Hits 48632 100944 +52312
+ Misses 73850 29398 -44452
- Partials 6329 8017 +1688
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@coderzc |
PIP: #16763
Motivation & Modifications
Make the timer execute immediately after the load index.
Improve method name
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: