Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][proxy] ProxyConnection should not call super.exceptionCaught #19990

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

michaeljmarshall
Copy link
Member

Motivation

While debugging an issue, I noticed that we call super.exceptionCaught(ctx, cause); in the ProxyConnection class. This leads to the following log line:

An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception. io.netty.channel.unix.Errors$NativeIoException: recvAddress(..) failed: Connection reset by peer

Because we always handle exceptions, there is no need to forward them to the next handler.

Modifications

  • Remove a single method call

Verifying this change

This is a trivial change. Note that we do not call the super method in any other handler implementations in the project.

Documentation

  • doc-not-needed

Matching PR in forked repository

PR in forked repository: skipping PR for this trivial change

@michaeljmarshall michaeljmarshall added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/proxy doc-not-needed Your PR changes do not impact docs ready-to-test labels Apr 1, 2023
@michaeljmarshall michaeljmarshall added this to the 3.0.0 milestone Apr 1, 2023
@michaeljmarshall michaeljmarshall self-assigned this Apr 1, 2023
@lhotari
Copy link
Member

lhotari commented Apr 1, 2023

I guess the only problem that the method call caused is the extra log line?

@lhotari
Copy link
Member

lhotari commented Apr 1, 2023

/pulsarbot rerun-failure-checks

@michaeljmarshall
Copy link
Member Author

I guess the only problem that the method call caused is the extra log line?

Correct. The only problem was an extra log line. It is only a cosmetic issue, as far as I can tell.

@michaeljmarshall
Copy link
Member Author

/pulsarbot rerun-failure-checks

@michaeljmarshall michaeljmarshall merged commit 67eb0fb into apache:master Apr 3, 2023
@michaeljmarshall michaeljmarshall deleted the reduce-logging branch April 3, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants