[cleanup][proxy] ProxyConnection should not call super.exceptionCaught #19990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While debugging an issue, I noticed that we call
super.exceptionCaught(ctx, cause);
in theProxyConnection
class. This leads to the following log line:Because we always handle exceptions, there is no need to forward them to the next handler.
Modifications
Verifying this change
This is a trivial change. Note that we do not call the super method in any other handler implementations in the project.
Documentation
doc-not-needed
Matching PR in forked repository
PR in forked repository: skipping PR for this trivial change