Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-192: Filter the transfer dest broker #19958

Conversation

Demogorgon314
Copy link
Member

Master Issue: #16691

Motivation

The PIP-192 introduced transfer to transfer the bundle from ower broker to a specific broker without unloading,
But the dest broker is not filtered by the broker filter.

Modifications

  • Filter out the dest broker by broker filter.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 self-assigned this Mar 29, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 29, 2023
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-filter-dest-broker branch from 9f2a551 to abee92c Compare March 30, 2023 08:45
@Demogorgon314 Demogorgon314 marked this pull request as ready for review March 30, 2023 13:13
@Demogorgon314 Demogorgon314 added ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Mar 31, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #19958 (aaa8711) into master (68c10ee) will decrease coverage by 0.08%.
The diff coverage is 82.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19958      +/-   ##
============================================
- Coverage     72.88%   72.80%   -0.08%     
+ Complexity    31616    31576      -40     
============================================
  Files          1861     1861              
  Lines        137356   137353       -3     
  Branches      15117    15115       -2     
============================================
- Hits         100111   100000     -111     
- Misses        29291    29385      +94     
- Partials       7954     7968      +14     
Flag Coverage Δ
inttests 24.28% <0.00%> (+<0.01%) ⬆️
systests 25.12% <0.00%> (+0.08%) ⬆️
unittests 72.09% <82.50%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tensions/filter/AntiAffinityGroupPolicyFilter.java 83.33% <ø> (+11.90%) ⬆️
...e/extensions/filter/BrokerMaxTopicCountFilter.java 87.50% <ø> (-1.39%) ⬇️
...balance/extensions/filter/BrokerVersionFilter.java 80.39% <ø> (-0.38%) ⬇️
...nsions/policies/AntiAffinityGroupPolicyHelper.java 77.27% <0.00%> (-13.36%) ⬇️
...tensions/filter/BrokerIsolationPoliciesFilter.java 88.88% <66.66%> (ø)
...dbalance/extensions/scheduler/TransferShedder.java 83.07% <86.20%> (+1.64%) ⬆️
...dbalance/extensions/ExtensibleLoadManagerImpl.java 76.21% <100.00%> (+0.14%) ⬆️
...e/extensions/policies/IsolationPoliciesHelper.java 87.50% <100.00%> (+0.83%) ⬆️

... and 68 files with indirect coverage changes

@Demogorgon314
Copy link
Member Author

@gaoran10 @Technoboy- PTAL by any chance.

@Technoboy- Technoboy- added this to the 3.0.0 milestone Apr 5, 2023
@Technoboy- Technoboy- merged commit 7813dab into apache:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants