[fix][client] Fix client erroneous code comments #19915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
RobertIndie
reviewed
Mar 24, 2023
...1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java
Outdated
Show resolved
Hide resolved
RobertIndie
approved these changes
Mar 24, 2023
AnonHxy
approved these changes
Mar 27, 2023
|
LGTM |
Signed-off-by: tison <[email protected]>
|
@crossoverJie CI failed. I've fixed for you this time. Please check the status report and fix by yourself the next time :) |
tisonkun
approved these changes
Mar 29, 2023
Codecov Report
@@ Coverage Diff @@
## master #19915 +/- ##
=============================================
+ Coverage 25.11% 72.79% +47.67%
- Complexity 205 31476 +31271
=============================================
Files 1680 1859 +179
Lines 127176 136836 +9660
Branches 13863 15049 +1186
=============================================
+ Hits 31942 99611 +67669
+ Misses 90242 29309 -60933
- Partials 4992 7916 +2924
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Merging... Thanks for your contribution @crossoverJie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix incorrect comments.
Documentation
docdoc-requireddoc-not-neededdoc-complete