Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][io][broker] Updated org.reflections-reflections library version #19898

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

abhilashmandaliya
Copy link
Contributor

@abhilashmandaliya abhilashmandaliya commented Mar 22, 2023

Motivation

While looking at some reflection related code, stumbled upon the library version and released that there is a new version that has fixes for various CVEs

Modifications

Upgraded org.reflections-reflections library from 0.9.11 to 0.10.2.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/abhilashmandaliya/pulsar

* Upgraded quite old reflection library version to the latest one which addresses several CVEs
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 22, 2023
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@abhilashmandaliya
Copy link
Contributor Author

/pulsarbot run-failure-checks

@abhilashmandaliya
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@abhilashmandaliya abhilashmandaliya changed the title Updated reflection library version [improve][io][broker] Updated reflection library version Mar 24, 2023
@abhilashmandaliya
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@abhilashmandaliya
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@abhilashmandaliya abhilashmandaliya changed the title [improve][io][broker] Updated reflection library version [improve][io][broker] Updated org.reflections-reflections library version Mar 24, 2023
@eolivelli eolivelli merged commit f1f8dab into apache:master Mar 24, 2023
@eolivelli
Copy link
Contributor

merged to master branch ! thank you @abhilashmandaliya

@abhilashmandaliya abhilashmandaliya deleted the patch-1 branch March 24, 2023 11:22
@abhilashmandaliya
Copy link
Contributor Author

merged to master branch ! thank you @abhilashmandaliya

Thanks a lot, @eolivelli, especially, for guiding me through the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants