[improve][broker] PIP-192: Add metrics for unload operation #19749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
added
type/enhancement
heesung-sn
reviewed
Mar 8, 2023
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/UnloadScheduler.java
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/UnloadScheduler.java
Outdated
Show resolved
Hide resolved
...oker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/UnloadCounter.java
Outdated
Show resolved
Hide resolved
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192_Add-metrics-for-unload
branch
from
bbc784b to
b704214
Compare
heesung-sn
approved these changes
Mar 12, 2023
gaoran10
approved these changes
Mar 13, 2023
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192_Add-metrics-for-unload
branch
from
926b01d to
687bd31
Compare
|
/pulsarbot run-failure-checks |
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192_Add-metrics-for-unload
branch
from
687bd31 to
b4efd9e
Compare
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192_Add-metrics-for-unload
branch
from
786b428 to
3f89bc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16691
Motivation
Raising a PR to implement #16691.
We need to support metrics for unload/transfer operations in Load Manager Extension.
Modifications
In this PR:
findBundlesForUnloadingmethod return type fromUnloadDecisiontoSet<UnloadDecision>.UnloadDecisionno longer contains all unload objects. Each unload object has its own reason.Documentation
docdoc-requireddoc-not-neededdoc-complete