[feat][broker][PIP-195] Add metrics for bucket delayed message tracker #19716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
added
type/feature
coderzc
force-pushed
the
bucket_delayed_mertices
branch
from
3944bd1 to
1d0d7d7
Compare
dao-jun
reviewed
Mar 13, 2023
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/StatsBuckets.java
Outdated
Show resolved
Hide resolved
coderzc
force-pushed
the
bucket_delayed_mertices
branch
5 times, most recently
from
bff1402 to
a0a917e
Compare
mattisonchao
approved these changes
Mar 29, 2023
coderzc
force-pushed
the
bucket_delayed_mertices
branch
from
a0a917e to
a776d18
Compare
coderzc
force-pushed
the
bucket_delayed_mertices
branch
from
e0486bd to
067cc2c
Compare
coderzc
force-pushed
the
bucket_delayed_mertices
branch
from
f56fcd7 to
8b8ec82
Compare
coderzc
force-pushed
the
bucket_delayed_mertices
branch
from
921158f to
f10b352
Compare
coderzc
commented
Mar 29, 2023
| @@ -212,8 +208,8 @@ private CompletableFuture<Void> addEntry(LedgerHandle ledgerHandle, byte[] data) | |||
| }); | |||
| } | |||
|
|
|||
| CompletableFuture<Enumeration<LedgerEntry>> getLedgerEntryThenCloseLedger(LedgerHandle ledger, | |||
| long firstEntryId, long lastEntryId) { | |||
| CompletableFuture<Enumeration<LedgerEntry>> getLedgerEntry(LedgerHandle ledger, | |||
There was a problem hiding this comment.
Ledger is already closed after createBucketSnapshot, so we don't need to close it again.
coderzc
force-pushed
the
bucket_delayed_mertices
branch
from
18952cf to
64967e8
Compare
| * Tells whether this DelayedDeliveryTracker contains this message index, | ||
| * if the tracker is not supported it or disabled this feature also will return false. | ||
| */ | ||
| boolean containsMessage(long ledgerId, long entryId); |
There was a problem hiding this comment.
Why did we remove this method in this PR?
There was a problem hiding this comment.
Oh, sorry this addresses a previous comment.
See: #17677 (review)
There was a problem hiding this comment.
Thanks for the context!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16763
Motivation
Add metrics for bucket delayed message tracker.
Modifications
The new metrics and change metrics:
statelabel can besucceed,failed,all(theallmeans is the total number of all states) and thetypelabel can becreate,load,delete,merge.typelabel can becreate,load,delete,mergeThe label
quantilecan be:containsMessagefrom DelayedDeliveryTracker interface ([feat][broker][PIP-195] Implement BookkeeperBucketSnapshotStorage - part3 #17677 (review))closeLedgeraftergetLedgerEntryVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: