-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] PIP-192 Added broker and top-bundles load reporters #19471
[improve][broker] PIP-192 Added broker and top-bundles load reporters #19471
Conversation
cc6e9a3
to
cc9203c
Compare
} | ||
} catch (Throwable e) { | ||
log.error("Failed to report top-bundles load data.", e); | ||
return CompletableFuture.failedFuture(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to catch exception ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to wrap any unexpected exception and continue the next run on the scheduler thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but seems no error from generateLoadData
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this try-catch, and added try-catch to the scheduler.
b096091
to
2201a18
Compare
...in/java/org/apache/pulsar/broker/loadbalance/extensions/reporter/BrokerLoadDataReporter.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pulsar/broker/loadbalance/extensions/reporter/BrokerLoadDataReporter.java
Outdated
Show resolved
Hide resolved
f85557f
to
35829b3
Compare
35829b3
to
3dcea01
Compare
2f6c28d
to
76d004d
Compare
76d004d
to
3879428
Compare
Master Issue: #16691
Motivation
We will start raising PRs to implement PIP-192, #16691
Modifications
This PR added broker and .top-bundles load data reporters.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
We will have separate PRs to update the Doc later.
Matching PR in forked repository
PR in forked repository: heesung-sn#29