-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][ci] Fix pulsar shell bin file name #19378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current master the names are:
- apache-pulsar-shell-2.12.0-SNAPSHOT-bin.tar.gz
- apache-pulsar-shell-2.12.0-SNAPSHOT-bin.zip
maybe this is only related to branch-2.11 ?
For master and branch-2.11, both have |
I have fixed this on branch-2.11 when releasing 2.11 |
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19378 +/- ##
=============================================
+ Coverage 26.61% 62.84% +36.22%
- Complexity 6358 25614 +19256
=============================================
Files 1568 1822 +254
Lines 120927 133218 +12291
Branches 13216 14669 +1453
=============================================
+ Hits 32189 83720 +51531
+ Misses 84128 41794 -42334
- Partials 4610 7704 +3094
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation
The shell distribution files' name are like
apache-pulsar-shell-$VERSION-shell-bin.tar.gz
andapache-pulsar-shell-$VERSION-shell-bin.zip
which are incorrect instage-release.sh
.Modifications
Add suffix
-bin
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: https://github.com/yaalsn/pulsar/pull/17