Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] Fix pulsar shell bin file name #19378

Merged
merged 2 commits into from
Feb 1, 2023
Merged

[fix][ci] Fix pulsar shell bin file name #19378

merged 2 commits into from
Feb 1, 2023

Conversation

yaalsn
Copy link
Contributor

@yaalsn yaalsn commented Jan 31, 2023

Motivation

The shell distribution files' name are like apache-pulsar-shell-$VERSION-shell-bin.tar.gz and apache-pulsar-shell-$VERSION-shell-bin.zip which are incorrect in stage-release.sh.

image

Modifications

Add suffix -bin

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/yaalsn/pulsar/pull/17

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 31, 2023
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current master the names are:

  • apache-pulsar-shell-2.12.0-SNAPSHOT-bin.tar.gz
  • apache-pulsar-shell-2.12.0-SNAPSHOT-bin.zip

maybe this is only related to branch-2.11 ?

@yaalsn
Copy link
Contributor Author

yaalsn commented Jan 31, 2023

In the current master the names are:

  • apache-pulsar-shell-2.12.0-SNAPSHOT-bin.tar.gz
  • apache-pulsar-shell-2.12.0-SNAPSHOT-bin.zip

maybe this is only related to branch-2.11 ?

For master and branch-2.11, both have -bin suffix, so this PR needs to cherry-pick to branch-2.11.

@yaalsn
Copy link
Contributor Author

yaalsn commented Jan 31, 2023

image

@yaalsn yaalsn requested a review from nicoloboschi February 1, 2023 02:35
@Technoboy- Technoboy- added this to the 3.0.0 milestone Feb 1, 2023
@Technoboy- Technoboy- closed this Feb 1, 2023
@Technoboy- Technoboy- reopened this Feb 1, 2023
@Technoboy-
Copy link
Contributor

In the current master the names are:

  • apache-pulsar-shell-2.12.0-SNAPSHOT-bin.tar.gz
  • apache-pulsar-shell-2.12.0-SNAPSHOT-bin.zip

maybe this is only related to branch-2.11 ?

For master and branch-2.11, both have -bin suffix, so this PR needs to cherry-pick to branch-2.11.

I have fixed this on branch-2.11 when releasing 2.11

@yaalsn
Copy link
Contributor Author

yaalsn commented Feb 1, 2023

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

Merging #19378 (533fd17) into master (1cd1aef) will increase coverage by 36.22%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19378       +/-   ##
=============================================
+ Coverage     26.61%   62.84%   +36.22%     
- Complexity     6358    25614    +19256     
=============================================
  Files          1568     1822      +254     
  Lines        120927   133218    +12291     
  Branches      13216    14669     +1453     
=============================================
+ Hits          32189    83720    +51531     
+ Misses        84128    41794    -42334     
- Partials       4610     7704     +3094     
Flag Coverage Δ
inttests 24.85% <ø> (+<0.01%) ⬆️
systests 25.65% <ø> (?)
unittests 59.96% <ø> (+42.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pulsar/common/api/AuthData.java 71.42% <0.00%> (ø)
.../apache/pulsar/broker/namespace/LookupOptions.java 87.50% <0.00%> (ø)
.../apache/pulsar/common/naming/SystemTopicNames.java 55.55% <0.00%> (ø)
...apache/pulsar/common/util/SafeCollectionUtils.java 0.00% <0.00%> (ø)
.../apache/pulsar/client/api/MessageAcknowledger.java 0.00% <0.00%> (ø)
...pache/pulsar/common/configuration/BindAddress.java 22.22% <0.00%> (ø)
...lsar/client/impl/conf/ReaderConfigurationData.java 81.39% <0.00%> (ø)
...r/client/admin/internal/data/AuthPoliciesImpl.java 65.21% <0.00%> (ø)
...sar/common/policies/data/impl/BundlesDataImpl.java 92.30% <0.00%> (ø)
...ar/common/policies/data/InactiveTopicPolicies.java 83.33% <0.00%> (ø)
... and 1336 more

@nicoloboschi nicoloboschi merged commit 34c1870 into apache:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants