[improve][cli] improve admin set-backlog-quota more clear
#19300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
github-actions
bot
added
doc-complete
| @@ -977,8 +977,8 @@ private class SetBacklogQuota extends CliCommand { | |||
| private String policyStr; | |||
|
|
|||
| @Parameter(names = {"-t", "--type"}, description = "Backlog quota type to set. Valid options are: " | |||
| + "destination_storage and message_age. " | |||
| + "destination_storage limits backlog by size (in bytes). " | |||
| + "destination_storage (default) and message_age. " | |||
There was a problem hiding this comment.
The default is backlog size, right?
codelipenghui
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19196
Motivation
The parameters of backlog retention policies need to be clarified. Size limit is only useful in
destination_storageand time limit is only useful inmessage_age.Modifications
--limitoptional, becausemessage_agedoesn't need this parameter but this parameter isrequirednow.message_age, use the time limit and ignore the size limit. When the quota type isdestination_storage, use the size limit and ignore the time limit. Don't set them both, which can be confusing for users.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completedoc update: apache/pulsar-site#394
Matching PR in forked repository
PR in forked repository: labuladong#19