-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][txn] Always send correct transaction id in end txn response #19137
Conversation
FYI @madhavan-narayanan since you implemented the interceptor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its better to add test for it
Added, thanks. |
Codecov Report
@@ Coverage Diff @@
## master #19137 +/- ##
============================================
+ Coverage 47.00% 49.82% +2.82%
+ Complexity 10639 8421 -2218
============================================
Files 713 478 -235
Lines 69672 53000 -16672
Branches 7482 5663 -1819
============================================
- Hits 32746 26405 -6341
+ Misses 33212 23642 -9570
+ Partials 3714 2953 -761
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ache#19137) (cherry picked from commit 90764e7)
Motivation
When the broker sends the transaction end response which has failed, the least sig bits is not included in the response payload. This also applies to other txn methods.
This is not a big deal since the java client only uses it for debug logging.
However, thanks to #14613, it's possible to intercept this response payload so it's better to pass the correct value.
Modifications
TxnidLeastBits
in txn response payloadsVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc
doc-required
doc-not-needed
doc-complete