[fix][broker] fix ttl expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true #19132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2023
AnonHxy
reviewed
Jan 6, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
AnonHxy
reviewed
Jan 6, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
aloyszhang
force-pushed
the
ttl-no-recoverable
branch
from
fd21d3d to
5284ddb
Compare
…pNonRecoverableData=true
aloyszhang
force-pushed
the
ttl-no-recoverable
branch
from
979ffc6 to
bd6966e
Compare
|
@AnonHxy PTAL again, thx. |
Codecov Report
@@ Coverage Diff @@
## master #19132 +/- ##
============================================
- Coverage 47.73% 47.35% -0.38%
+ Complexity 10819 10735 -84
============================================
Files 712 713 +1
Lines 69645 69674 +29
Branches 7481 7483 +2
============================================
- Hits 33242 32995 -247
- Misses 32699 32960 +261
- Partials 3704 3719 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AnonHxy
approved these changes
Jan 8, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19131
Motivation
fix TTL expiration block due to no-recoverable exception even if autoSkipNonRecoverableData=true
Modifications
In the logic of message expiration, if met
NonRecoverableLedgerExceptionwhen reading the oldest msg, just skip these msgs if autoSkipNonRecoverableData is set to true.Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository:[ ]
aloyszhang#10