[improve][broker] PIP-192: Implement broker version filter for new load manager #19023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
force-pushed
the
Demogorgon314/Implement_broker_filter
branch
from
e445817 to
73b850d
Compare
heesung-sn
reviewed
Dec 27, 2022
...rc/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerVersionFilter.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerVersionFilter.java
Outdated
Show resolved
Hide resolved
| log.info("Latest broker version found was [{}]", latestVersion); | ||
| } catch (Exception ex) { | ||
| log.warn("Disabling PreferLaterVersions feature; reason: " + ex.getMessage()); | ||
| throw new BrokerFilterBadVersionException("Cannot determine newest broker version: " + ex.getMessage()); |
There was a problem hiding this comment.
If an exception is thrown here, do we skip this filter?
There was a problem hiding this comment.
Yes, we should handle the exception when using the filter.
Demogorgon314
force-pushed
the
Demogorgon314/Implement_broker_filter
branch
from
73b850d to
a40e190
Compare
heesung-sn
approved these changes
Dec 28, 2022
codelipenghui
approved these changes
Dec 30, 2022
codelipenghui
added
the
type/feature
|
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19023 +/- ##
=============================================
- Coverage 47.74% 35.60% -12.14%
+ Complexity 10623 8272 -2351
=============================================
Files 703 772 +69
Lines 68828 74282 +5454
Branches 7381 7994 +613
=============================================
- Hits 32861 26449 -6412
- Misses 32307 44318 +12011
+ Partials 3660 3515 -145
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Demogorgon314
force-pushed
the
Demogorgon314/Implement_broker_filter
branch
from
a40e190 to
f670d64
Compare
Technoboy-
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We will start raising PRs to implement PIP-192, #16691
Modifications
This PR Added
BrokerVersionFilterto the load balancer extensions and its unit test.For the pip-192 project, this
BrokerVersionFilterorg.apache.pulsar.broker.loadbalance.impl.BrokerVersionFilter.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Demogorgon314#9