Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Add oshi library to help control OS resources. #18990

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

mattisonchao
Copy link
Member

Motivation

Add oshi library to help control OS resources.

ML: https://lists.apache.org/thread/sgod6pk5r8jgzjm6fqkcw10d88hp75t5

Modifications

  • Add dependency oshi

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao added area/broker area/dependency Pull requests that update a dependency file labels Dec 20, 2022
@mattisonchao mattisonchao added this to the 2.12.0 milestone Dec 20, 2022
@mattisonchao mattisonchao self-assigned this Dec 20, 2022
@mattisonchao mattisonchao reopened this Dec 20, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #18990 (e6bcb16) into master (002fa49) will increase coverage by 3.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18990      +/-   ##
============================================
+ Coverage     46.91%   50.43%   +3.51%     
- Complexity    10557    12533    +1976     
============================================
  Files           703      713      +10     
  Lines         68852    78582    +9730     
  Branches       7386     9463    +2077     
============================================
+ Hits          32303    39631    +7328     
- Misses        32968    34824    +1856     
- Partials       3581     4127     +546     
Flag Coverage Δ
unittests 50.43% <ø> (+3.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/apache/bookkeeper/mledger/ManagedCursor.java 50.00% <0.00%> (-35.72%) ⬇️
...ar/broker/loadbalance/impl/BundleSplitterTask.java 55.55% <0.00%> (-24.45%) ⬇️
...g/apache/bookkeeper/mledger/util/StatsBuckets.java 43.75% <0.00%> (-16.67%) ⬇️
...ookkeeper/mledger/impl/ManagedLedgerMBeanImpl.java 53.17% <0.00%> (-9.53%) ⬇️
.../pulsar/broker/service/SharedConsumerAssignor.java 68.51% <0.00%> (-9.26%) ⬇️
...er/loadbalance/impl/ModularLoadManagerWrapper.java 79.41% <0.00%> (-5.96%) ⬇️
...balance/impl/SimpleResourceAllocationPolicies.java 48.57% <0.00%> (-5.72%) ⬇️
...e/bookkeeper/mledger/impl/LedgerMetadataUtils.java 68.42% <0.00%> (-4.92%) ⬇️
...roker/service/persistent/MessageDeduplication.java 50.65% <0.00%> (-3.06%) ⬇️
...delayed/InMemoryDelayedDeliveryTrackerFactory.java 88.23% <0.00%> (-2.68%) ⬇️
... and 98 more

Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao mattisonchao reopened this Jan 6, 2023
@mattisonchao mattisonchao merged commit 96f8262 into master Jan 9, 2023
@mattisonchao mattisonchao deleted the import_oshi branch January 9, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker area/dependency Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants