[fix][broker] Fix possible race condition in completing topic list watcher #18624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrasbeni Please review. |
Codecov Report
@@ Coverage Diff @@
## master #18624 +/- ##
============================================
- Coverage 47.39% 37.52% -9.88%
+ Complexity 10479 7896 -2583
============================================
Files 698 698
Lines 68070 68079 +9
Branches 7279 7280 +1
============================================
- Hits 32264 25547 -6717
- Misses 32228 39217 +6989
+ Partials 3578 3315 -263
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BewareMyPower
approved these changes
Nov 25, 2022
labuladong
pushed a commit
to labuladong/pulsar
that referenced
this pull request
Nov 28, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While reading code in TopicListService, I noticed a race condition that could happen in the case where the connection is closing and there's a TopicListWatcher that is in being initialized.
Modifications
Add check to see if the watcherFuture can be completed. If not, deregister the watcher.
Documentation
docdoc-requireddoc-not-neededdoc-complete