Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix flaky test AdditionalServletsTest.testEmptyStringAsExtractionDirectory #18607

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

andrasbeni
Copy link
Contributor

@andrasbeni andrasbeni commented Nov 24, 2022

Fixes #18587

Motivation

AdditionalServletsTest.testEmptyStringAsExtractionDirectory is flaky because it depends on NarClassLoader#DEFAULT_NAR_EXTRACTION_DIR being initialized after the test is begun.

Modifications

Remove the override of the tmp directory from the test.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

  • This change only modifies test code

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: andrasbeni#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 24, 2022
@andrasbeni andrasbeni changed the title [fix][test]Fix flaky test AdditionalServletsTest.testEmptyStringAsExtractionDirectory [fix][test] Fix flaky test AdditionalServletsTest.testEmptyStringAsExtractionDirectory Nov 24, 2022
@lhotari
Copy link
Member

lhotari commented Nov 24, 2022

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #18607 (6e37bda) into master (598ca5d) will decrease coverage by 6.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18607      +/-   ##
============================================
- Coverage     47.72%   41.63%   -6.09%     
+ Complexity     9330     2407    -6923     
============================================
  Files           618      235     -383     
  Lines         58568    16666   -41902     
  Branches       6093     1818    -4275     
============================================
- Hits          27951     6939   -21012     
+ Misses        27589     8968   -18621     
+ Partials       3028      759    -2269     
Flag Coverage Δ
unittests 41.63% <ø> (-6.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/apache/pulsar/client/impl/ConnectionPool.java 37.43% <0.00%> (-1.03%) ⬇️
...a/org/apache/pulsar/client/impl/TableViewImpl.java 0.00% <0.00%> (ø)
...pache/pulsar/client/impl/TableViewBuilderImpl.java 0.00% <0.00%> (ø)
...pache/pulsar/broker/admin/v2/PersistentTopics.java
...org/apache/pulsar/broker/service/Subscription.java
.../broker/intercept/BrokerInterceptorDefinition.java
...rg/apache/pulsar/broker/web/PulsarWebResource.java
...ava/org/apache/pulsar/broker/stats/TimeWindow.java
...g/apache/pulsar/broker/service/StreamingStats.java
...g/TopicCountEquallyDivideBundleSplitAlgorithm.java
... and 383 more

@lhotari lhotari merged commit bf3ee85 into apache:master Nov 24, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Dec 6, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky-test: AdditionalServletsTest.testEmptyStringAsExtractionDirectory
5 participants