-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client] Allow customize subscription name for TableView #18596
Merged
eolivelli
merged 2 commits into
apache:master
from
freeznet:freeznet/table-view-allow-customize-subscription-name
Nov 24, 2022
Merged
[improve][client] Allow customize subscription name for TableView #18596
eolivelli
merged 2 commits into
apache:master
from
freeznet:freeznet/table-view-allow-customize-subscription-name
Nov 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
label
Nov 24, 2022
freeznet
added
ready-to-test
and removed
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
labels
Nov 24, 2022
github-actions
bot
added
the
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
label
Nov 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #18596 +/- ##
============================================
- Coverage 47.39% 46.76% -0.64%
+ Complexity 10479 10341 -138
============================================
Files 698 698
Lines 68070 68076 +6
Branches 7279 7279
============================================
- Hits 32264 31834 -430
- Misses 32228 32639 +411
- Partials 3578 3603 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nodece
approved these changes
Nov 24, 2022
eolivelli
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Technoboy-
changed the title
[improve][client] allow customize subscription name for TableView
[improve][client] Allow customize subscription name for TableView
Nov 28, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
ready-to-test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TableView does not allow the user to customize the subscription name and is not friendly when clusters have strict permission setups (like the need to create the subscription name manually).
Modifications
subscriptionName
to the internal ReaderVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: