Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] Allow customize subscription name for TableView #18596

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Nov 24, 2022

Motivation

TableView does not allow the user to customize the subscription name and is not friendly when clusters have strict permission setups (like the need to create the subscription name manually).

Modifications

  • pass subscriptionName to the internal Reader

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@freeznet freeznet self-assigned this Nov 24, 2022
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 24, 2022
@freeznet freeznet added ready-to-test and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Nov 24, 2022
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #18596 (a112da5) into master (cd85a67) will decrease coverage by 0.63%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18596      +/-   ##
============================================
- Coverage     47.39%   46.76%   -0.64%     
+ Complexity    10479    10341     -138     
============================================
  Files           698      698              
  Lines         68070    68076       +6     
  Branches       7279     7279              
============================================
- Hits          32264    31834     -430     
- Misses        32228    32639     +411     
- Partials       3578     3603      +25     
Flag Coverage Δ
unittests 46.76% <14.28%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/pulsar/client/impl/TableViewBuilderImpl.java 0.00% <0.00%> (ø)
...a/org/apache/pulsar/client/impl/TableViewImpl.java 0.00% <0.00%> (ø)
...pulsar/client/impl/TableViewConfigurationData.java 33.33% <50.00%> (+33.33%) ⬆️
.../transaction/buffer/metadata/AbortTxnMetadata.java 28.57% <0.00%> (-57.15%) ⬇️
...ion/buffer/metadata/TransactionBufferSnapshot.java 42.85% <0.00%> (-42.86%) ⬇️
...lsar/broker/loadbalance/impl/ThresholdShedder.java 3.26% <0.00%> (-39.87%) ⬇️
...saction/timeout/TransactionTimeoutTrackerImpl.java 50.87% <0.00%> (-36.85%) ⬇️
...er/impl/SingleSnapshotAbortedTxnProcessorImpl.java 51.19% <0.00%> (-29.77%) ⬇️
.../apache/pulsar/broker/loadbalance/LoadManager.java 61.11% <0.00%> (-16.67%) ⬇️
...nsaction/pendingack/impl/PendingAckHandleImpl.java 36.76% <0.00%> (-15.08%) ⬇️
... and 47 more

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit fe5a8ce into apache:master Nov 24, 2022
@Technoboy- Technoboy- changed the title [improve][client] allow customize subscription name for TableView [improve][client] Allow customize subscription name for TableView Nov 28, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Nov 28, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants