[fix][offload] Fix numerical overflow bug while reading data from tiered storage #18595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot rerun-failure-checks |
|
The test failed but seems not relate to this pr. |
Technoboy-
approved these changes
Nov 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #18595 +/- ##
=============================================
- Coverage 47.39% 28.29% -19.10%
+ Complexity 10479 5366 -5113
=============================================
Files 698 618 -80
Lines 68070 58577 -9493
Branches 7279 6094 -1185
=============================================
- Hits 32264 16577 -15687
- Misses 32228 39656 +7428
+ Partials 3578 2344 -1234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lifepuzzlefun
approved these changes
Nov 26, 2022
lifepuzzlefun
approved these changes
Nov 26, 2022
lhotari
approved these changes
Nov 28, 2022
lhotari
pushed a commit
that referenced
this pull request
Nov 28, 2022
…red storage (#18595) Co-authored-by: druidliu <[email protected]> (cherry picked from commit 5c34e84)
lhotari
pushed a commit
that referenced
this pull request
Nov 28, 2022
…red storage (#18595) Co-authored-by: druidliu <[email protected]> (cherry picked from commit 5c34e84)
lhotari
pushed a commit
that referenced
this pull request
Nov 28, 2022
…red storage (#18595) Co-authored-by: druidliu <[email protected]> (cherry picked from commit 5c34e84)
lhotari
added
cherry-picked/branch-2.9
lhotari
pushed a commit
that referenced
this pull request
Nov 28, 2022
…red storage (#18595) Co-authored-by: druidliu <[email protected]> (cherry picked from commit 5c34e84)
lhotari
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2022
…red storage (apache#18595) Co-authored-by: druidliu <[email protected]> (cherry picked from commit 5c34e84)
|
Nice catch! |
2 tasks
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
…red storage (apache#18595) Co-authored-by: druidliu <[email protected]>
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
…red storage (apache#18595) Co-authored-by: druidliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18580
Motivation
Fix numerical overflow bug while reading data from tiered storage.
Modifications
Fix the
BlobStoreBackedInputStreamImpl.available.Verifying this change
This change is hard to add test case because it might cause OOM.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dragonls#5