Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference landing page and update link #18585

Merged
merged 38 commits into from
Nov 24, 2022
Merged

Conversation

DaveDuggins
Copy link
Contributor

Motivation

Need a landing page for References content block.

Modifications

Added reference landing page with links to reference resources.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

DaveDuggins and others added 30 commits November 7, 2022 20:20
@DaveDuggins DaveDuggins marked this pull request as ready for review November 23, 2022 21:08
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 23, 2022
@momo-jun
Copy link
Contributor

Hi @DaveDuggins, fyi - I've fixed the following syntax/style issues, including:

  1. Use double quotes " instead of for the sidebar_label field in the reference-landing.md file.
  2. Use --- instead of - following the sidebar_label field in the reference-landing.md file.
  3. Add reference-landing to the left navigation by updating the sidebars.json file.

The preview cannot succeed due to issues 1&2. Now it works as follows:

image

Another suggestion is - Create a separate PR in your forked repo for a new batch of changes. Currently, you are using the master branch of your repo as usual, so there is a long list of commit history, which is not necessary.

@momo-jun momo-jun merged commit 15be2da into apache:master Nov 24, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants