[improve][ci] Allow [fix][broker][branch-2.8] alike patten #18504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
michaeljmarshall
approved these changes
Nov 16, 2022
tisonkun
commented
Nov 16, 2022
tisonkun
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18504 +/- ##
============================================
+ Coverage 45.62% 47.30% +1.68%
- Complexity 10075 10460 +385
============================================
Files 697 697
Lines 68024 68015 -9
Branches 7293 7285 -8
============================================
+ Hits 31033 32176 +1143
+ Misses 33413 32245 -1168
- Partials 3578 3594 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Merging... Verified on https://regex101.com/ |
tisonkun
commented
Nov 17, 2022
| @@ -61,8 +61,8 @@ jobs: | |||
| # bk -> bookkeeper | |||
| scopes: | | |||
| admin | |||
| bk | |||
There was a problem hiding this comment.
@michaeljmarshall I find that you add bk and zk scopes. There're several overlapping scopes now:
zkvsmetabkvsmlvsstorage
How do you understand this situation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: