-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Unreasonable AuthenticationException reference #18502
Conversation
@zzccctv Please add the following content to your PR description and select a checkbox:
|
Codecov Report
@@ Coverage Diff @@
## master #18502 +/- ##
============================================
+ Coverage 45.67% 47.22% +1.55%
- Complexity 10075 10448 +373
============================================
Files 693 697 +4
Lines 67940 68015 +75
Branches 7273 7285 +12
============================================
+ Hits 31030 32122 +1092
+ Misses 33333 32307 -1026
- Partials 3577 3586 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/pulsarbot run-failure-checks |
…nce (apache#18502)" This reverts commit e5e5852.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreasonable AuthenticationException reference causes processing logic redundancy
I do not think authenticationException
was creating redundancy. With this PR merged, we will not longer get helpful stack traces in cases where we easily could. Further, it'll be harder to debug certain authentication exceptions.
@zzccctv - are you able to explain further how this code was unreasonable?
In order to progress the conversation, I created a PR to revert this commit #18529. We don't have to merge it if we can show that it is really valuable, but I would like additional context before closing it. Thanks!
I misread the original code. Please see #18529 for context. |
…che#18502) (cherry picked from commit e5e5852)
Motivation
Unreasonable AuthenticationException reference causes processing logic redundancy
Modifications
Delete unreasonable exception references
Documentation
doc
doc-required
doc-not-needed
doc-complete