-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup][test] remove redundant code #18487
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhangjian
approved these changes
Nov 16, 2022
codelipenghui
approved these changes
Nov 16, 2022
codelipenghui
added
area/test
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
labels
Nov 16, 2022
codelipenghui
changed the title
[improve][test] remove redundant code
[cleanup][test] remove redundant code
Nov 16, 2022
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18487 +/- ##
============================================
+ Coverage 45.62% 47.14% +1.52%
- Complexity 10075 10424 +349
============================================
Files 697 697
Lines 68024 68028 +4
Branches 7293 7291 -2
============================================
+ Hits 31033 32075 +1042
+ Misses 33413 32376 -1037
+ Partials 3578 3577 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
RobertIndie
approved these changes
Nov 16, 2022
/pulsarbot run-failure-checks |
/pulsarbot rerun-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/test
doc-not-needed
Your PR changes do not impact docs
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Remove redundant logic.
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: labuladong#8