Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][test] remove redundant code #18487

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Conversation

labuladong
Copy link
Contributor

Modifications

Remove redundant logic.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: labuladong#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 16, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Nov 16, 2022
@codelipenghui codelipenghui added area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Nov 16, 2022
@codelipenghui codelipenghui changed the title [improve][test] remove redundant code [cleanup][test] remove redundant code Nov 16, 2022
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #18487 (bf27881) into master (7975023) will increase coverage by 1.52%.
The diff coverage is 59.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18487      +/-   ##
============================================
+ Coverage     45.62%   47.14%   +1.52%     
- Complexity    10075    10424     +349     
============================================
  Files           697      697              
  Lines         68024    68028       +4     
  Branches       7293     7291       -2     
============================================
+ Hits          31033    32075    +1042     
+ Misses        33413    32376    -1037     
+ Partials       3578     3577       -1     
Flag Coverage Δ
unittests 47.14% <59.37%> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/impl/PulsarClientImplementationBindingImpl.java 72.41% <ø> (-0.47%) ⬇️
...ar/client/impl/conf/ConsumerConfigurationData.java 92.55% <ø> (+2.12%) ⬆️
...he/pulsar/client/impl/TypedMessageBuilderImpl.java 30.76% <59.37%> (+3.56%) ⬆️
...he/pulsar/client/impl/PartitionedProducerImpl.java 30.34% <0.00%> (-5.13%) ⬇️
...sar/broker/service/schema/SchemaRegistryStats.java 72.50% <0.00%> (-2.50%) ⬇️
...va/org/apache/pulsar/client/impl/ProducerImpl.java 15.84% <0.00%> (-1.17%) ⬇️
.../pulsar/client/impl/ProducerStatsRecorderImpl.java 84.04% <0.00%> (-0.62%) ⬇️
...apache/pulsar/proxy/server/LookupProxyHandler.java 57.75% <0.00%> (-0.44%) ⬇️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 63.70% <0.00%> (-0.14%) ⬇️
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 54.02% <0.00%> (+0.08%) ⬆️
... and 70 more

@labuladong
Copy link
Contributor Author

/pulsarbot run-failure-checks

@nodece
Copy link
Member

nodece commented Nov 16, 2022

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- merged commit 7b93e1a into apache:master Nov 18, 2022
@labuladong labuladong deleted the improve-test branch December 2, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants