Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Typos in ManagedLedgerImpl #18445

Merged

Conversation

hzh0425
Copy link
Member

@hzh0425 hzh0425 commented Nov 13, 2022

Motivation

Fix some spelling mistakes in ManagedLedgerImpl

Modifications

Fix some spelling mistakes in ManagedLedgerImpl

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

@github-actions
Copy link

@hzh0425 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 13, 2022
@tisonkun tisonkun changed the title [FIX][Broker]Fix some spelling mistakes in ManagedLedgerImpl [fix][broker]Fix some spelling mistakes in ManagedLedgerImpl Nov 15, 2022
@tisonkun tisonkun changed the title [fix][broker]Fix some spelling mistakes in ManagedLedgerImpl [fix][broker] Typos in ManagedLedgerImpl Nov 15, 2022
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.65%. Comparing base (b31c5a6) to head (9a31c00).
Report is 2195 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b31c5a6) and HEAD (9a31c00). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b31c5a6) HEAD (9a31c00)
unittests 7 5
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18445       +/-   ##
=============================================
- Coverage     46.98%   31.65%   -15.34%     
+ Complexity    10343     6718     -3625     
=============================================
  Files           692      693        +1     
  Lines         67766    67940      +174     
  Branches       7259     7273       +14     
=============================================
- Hits          31842    21504    -10338     
- Misses        32344    43388    +11044     
+ Partials       3580     3048      -532     
Flag Coverage Δ
unittests 31.65% <ø> (-15.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 53.93% <ø> (-0.05%) ⬇️

... and 189 files with indirect coverage changes

@tisonkun
Copy link
Member

Merging...

@tisonkun tisonkun merged commit aeb4503 into apache:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants