Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] fix permission denied error while running install-pulsar-client.sh #18444

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

nullscript
Copy link
Contributor

@nullscript nullscript commented Nov 13, 2022

Fixes #18443

Motivation

I tried to build docker image on my win10, and I use wsl2 for my docker, all my softwares versions are listed on #18443. I have encountered "permission denied" error while running install-pulsar-client.sh, seems it happens on some linux kernel. I searched this error on stackoverflow and I got this, https://stackoverflow.com/questions/69323982/permission-denied-in-docker-entrypoint. So I add RUN chmod +x /pulsar/bin/install-pulsar-client.sh, and it works fine for me.

Adding this may happen many beginner reduce this kind of problems.

Modifications

Add chmod +x command to dockerfile

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

@nullscript Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 13, 2022
@nullscript nullscript changed the title [fix][Dockerfile] fix permission denied error while running install-pulsar-client.sh [fix][build] fix permission denied error while running install-pulsar-client.sh Nov 13, 2022
@nullscript nullscript changed the title [fix][build] fix permission denied error while running install-pulsar-client.sh [fix][dockerfile] fix permission denied error while running install-pulsar-client.sh Nov 13, 2022
@nullscript nullscript changed the title [fix][dockerfile] fix permission denied error while running install-pulsar-client.sh [fix][build] fix permission denied error while running install-pulsar-client.sh Nov 13, 2022
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the original script works well on macOS for me.

@nodece nodece requested a review from lhotari November 14, 2022 04:02
@nodece nodece added this to the 2.12.0 milestone Nov 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #18444 (90e5ca6) into master (fdf86d3) will increase coverage by 1.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18444      +/-   ##
============================================
+ Coverage     45.67%   47.09%   +1.42%     
- Complexity    10075    10397     +322     
============================================
  Files           693      693              
  Lines         67940    67940              
  Branches       7273     7273              
============================================
+ Hits          31030    31998     +968     
+ Misses        33333    32368     -965     
+ Partials       3577     3574       -3     
Flag Coverage Δ
unittests 47.09% <ø> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) ⬇️
...he/pulsar/client/impl/PartitionedProducerImpl.java 30.34% <0.00%> (-5.13%) ⬇️
...oker/service/schema/SchemaRegistryServiceImpl.java 58.85% <0.00%> (-4.21%) ⬇️
.../pulsar/client/impl/ProducerStatsRecorderImpl.java 84.04% <0.00%> (-0.62%) ⬇️
...broker/service/schema/BookkeeperSchemaStorage.java 73.61% <0.00%> (-0.62%) ⬇️
...va/org/apache/pulsar/client/impl/ProducerImpl.java 16.43% <0.00%> (-0.59%) ⬇️
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 37.11% <0.00%> (-0.06%) ⬇️
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 53.93% <0.00%> (-0.05%) ⬇️
...ulsar/broker/namespace/NamespaceEphemeralData.java 86.36% <0.00%> (ø)
...pache/pulsar/broker/admin/impl/NamespacesBase.java 63.89% <0.00%> (+0.06%) ⬆️
... and 63 more

@tisonkun
Copy link
Member

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member

Merging...

Thanks for your contribution!

@tisonkun tisonkun merged commit a69e29d into apache:master Nov 15, 2022
@nullscript
Copy link
Contributor Author

Thanks for reviewing, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [build] /pulsar/bin/install-pulsar-client.sh: Permission denied
4 participants