-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] fix permission denied error while running install-pulsar-client.sh
#18444
Conversation
@nullscript Please add the following content to your PR description and select a checkbox:
|
install-pulsar-client.sh
install-pulsar-client.sh
install-pulsar-client.sh
install-pulsar-client.sh
install-pulsar-client.sh
install-pulsar-client.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the original script works well on macOS for me.
Codecov Report
@@ Coverage Diff @@
## master #18444 +/- ##
============================================
+ Coverage 45.67% 47.09% +1.42%
- Complexity 10075 10397 +322
============================================
Files 693 693
Lines 67940 67940
Branches 7273 7273
============================================
+ Hits 31030 31998 +968
+ Misses 33333 32368 -965
+ Partials 3577 3574 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/pulsarbot run-failure-checks |
Merging... Thanks for your contribution! |
Thanks for reviewing, guys! |
Fixes #18443
Motivation
I tried to build docker image on my win10, and I use wsl2 for my docker, all my softwares versions are listed on #18443. I have encountered "permission denied" error while running
install-pulsar-client.sh
, seems it happens on some linux kernel. I searched this error on stackoverflow and I got this, https://stackoverflow.com/questions/69323982/permission-denied-in-docker-entrypoint. So I addRUN chmod +x /pulsar/bin/install-pulsar-client.sh
, and it works fine for me.Adding this may happen many beginner reduce this kind of problems.
Modifications
Add
chmod +x
command to dockerfileVerifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete